Improve tool verification exit handling#6
Merged
Pnwcomputers merged 1 commit intomainfrom Oct 31, 2025
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
165
to
+169
| $totalIssues = $stats.BAD_SIZE + $stats.BAD_SIGNATURE + $stats.MISSING + $stats.CHECK_FAILED | ||
| if ($totalIssues -eq 0 -and $stats.VALID_MS -gt 0) { | ||
| if ($totalIssues -eq 0 -and ($stats.VALID_MS + $stats.VALID_OTHER + $stats.NOT_SIGNED) -gt 0) { | ||
| Write-Host "STATUS: All present tools are verified and safe to use" -ForegroundColor Green | ||
| } elseif ($totalIssues -gt 0) { | ||
| Write-Host "" | ||
| return $true |
There was a problem hiding this comment.
The new success condition returns $true when there are no size/signature errors and any tools were processed, even if every tool ended up in the NOT_SIGNED or VALID_OTHER buckets. In that scenario the batch launcher now exits with code 0 and prints “All tools validated successfully”, which implies the binaries are trustworthy even though none of them carry a Microsoft signature. The previous logic withheld a success status unless at least one Microsoft-signed tool was found. To avoid a false sense of safety, the function should still return $false (and therefore exit with code 2) when VALID_MS is zero so the caller can flag the result as a warning.
Useful? React with 👍 / 👎.
Pnwcomputers
added a commit
that referenced
this pull request
Oct 31, 2025
* Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error
Pnwcomputers
added a commit
that referenced
this pull request
Oct 31, 2025
* Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error
Pnwcomputers
added a commit
that referenced
this pull request
Oct 31, 2025
* Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error
Pnwcomputers
added a commit
that referenced
this pull request
Oct 31, 2025
* Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error
Pnwcomputers
added a commit
that referenced
this pull request
Oct 31, 2025
* VS AI Update (#8) * Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error * fix: address VS warnings - Rename Run-Tool -> Invoke-Tool - Replace use of with - Use Convert-ToolOutput in tool runner - Keep -Args support via [Alias('Args')]
Pnwcomputers
added a commit
that referenced
this pull request
Oct 31, 2025
* VS AI Update (#8) * Update SystemTester.bat * Update SystemTester.ps1 * Update SystemTester.bat * Update README.md * Update README.md * Update README.md * Update SystemTester.bat * Update SystemTester.ps1 * Update README.md * Create .gitkeep * Create CODE_OF_CONDUCT.md * Create CONTRIBUTING.md * Create PULL_REQUEST_TEMPLATE.md * Update CONTRIBUTING.md * Create bug_report.md * Create config.yml * Create deployment_issue.md * Create feature_request.md * Create implementation-question.md * Create COMPATABILITY.md * Create INSTALLATION.md * Create TROUBLESHOOTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Delete CONTRIBUTING.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Handle both script names in batch launcher (#3) * Add network speed and update visibility to reports (#4) * Improve GPU detection and batch reliability (#5) * Handle tool verification exit statuses (#6) * Update README.md * Fix host:port string interpolation in latency test (#7) * refactor: use approved verbs and fix analyzer issues - Clean-ToolOutput -> Convert-ToolOutput (+call site) - Run-Tool -> Invoke-Tool (+call sites) - Generate-Report -> New-Report (+call sites) - Replace param with (alias Args) - Avoid automatic var in PsPing - Fix comparison order - Remove unused var - Repair GPU submenu strings causing parse error * fix: address VS warnings - Rename Run-Tool -> Invoke-Tool - Replace use of with - Use Convert-ToolOutput in tool runner - Keep -Args support via [Alias('Args')]
Pnwcomputers
deleted the
codex/apply-fixes-from-review-to-batch-and-ps1-files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69050732fb1c8325ae986af05e8091bf